Detect dotted attribute names in STACK_GLOBAL (GHSA-5j3x-jp52-966f)#287
Merged
Conversation
Pickle resolves dotted names in imports, so STACK_GLOBAL "pathlib" "os.system" reaches the real os.system through pathlib. This is not limited to pathlib, it works with any stdlib module that imports a blocklisted module at top level We now split import names and compare every element with the blocklists. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pickle resolves dotted names in imports, so
STACK_GLOBAL "pathlib" "os.system"reaches the realos.systemthroughpathlib. This is not limited topathliband would work with any stdlib module that imports a blocklisted module at the top level. We now split import names and compare every element with the blocklists. Thanks to @seankohjs for the report!